Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Add funds" notification: Reduce nag level and add button to "Turn off notifications" #5469

Merged
merged 3 commits into from
Nov 9, 2016
Merged

"Add funds" notification: Reduce nag level and add button to "Turn off notifications" #5469

merged 3 commits into from
Nov 9, 2016

Commits on Nov 8, 2016

  1. Limit Add funds notification to once every 3 days 

    Related: #5418

Auditors: @bsclifton

Test Plan:
1. Trigger the "Add funds" notification.
  - Update reconcileStamp to <24 hours from now (or a few days in the past)
  - Ensure not enough balance
2. Change startup notification delay in ledger.js L484 from 15m to 5s
3. Open Brave and observe notification
4. Close Brave and reopen. Notification should not reappear.
(Next Add funds notification timestamp is set in Application Support/brave-development/session-store-1 `notification-add-funds-timestamp`)
    @ayumi
    ayumi committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    e2ecdad View commit details
    Browse the repository at this point in the history

  2. In Add funds notification add button to turn off notifications 

    Fix #5418

Auditors: @bsclifton

Test plan:
1. Trigger "Add funds" notification by having Payments enabled and editing session-store-1 reconcileDate to in the past
2. Observe notification with new "Turn off notification" button.
3. Click it
4. Open Preferences > Payments and click Advanced Settings... and observe notifications are disabled.
    @ayumi
    ayumi committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    aa08129 View commit details
    Browse the repository at this point in the history

  3. Add Turn off notifications to ledger notifications 

    Fix #5299

Auditors: @luixxiul
    @ayumi
    ayumi committed Nov 8, 2016
    1 Configuration menu
    Copy the full SHA
    967e5de View commit details
    Browse the repository at this point in the history