Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added margin-bottom to the transfer funds button on about:preferences#payments #6049

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Added margin-bottom to the transfer funds button on about:preferences#payments #6049

merged 1 commit into from
Dec 7, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 6, 2016

Labelled QA/no qa needed since this will be redone with #6047. Please skip QA for this.

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Closes #6048

Auditors: @bbondy

Test Plan:

  1. Open https://jsfiddle.net/LnwtLckc/5/
  2. Click register
  3. Make sure "Transfer BTC" button has the margin-bottom on add funds dialog on about:preferences#payments:

screenshot 2016-12-07 4 10 40

@bsclifton bsclifton self-assigned this Dec 7, 2016
@bsclifton
Copy link
Member

bsclifton commented Dec 7, 2016

Previous comment deleted- I didn't read your instructions, @luixxiul 😆

After opening the jsfiddle link and adding handler, it shows as expected and margin looks great 😄 Nice cleanup!

@luixxiul
Copy link
Contributor Author

Labelled QA/no qa needed as this was superseded with a8e5b89 of #6047

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants