This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this should work, but maybe another fix is needed for passing attributes to about pages, I'll merge this in the meantime either way though.
copyToClipboard.title=Copy to clipboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things ( cc: @liunkae ):
data-l10n-id
for this item. We need it to look like this:<span data-l10n-id='copyToClipboard' className='fa fa-clipboard' onClick={this.onCopy} />
app.properties
. Inside the en-US version of this file, you'll need to be having something like this:copyToClipboard.title=Copy to clipboard