Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Get each version in a more safe way; if one field fails, it won't break the whole thing #6410

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Get each version in a more safe way; if one field fails, it won't break the whole thing #6410

merged 1 commit into from
Dec 23, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Get each version in a more safe way; if one field fails, it won't break the whole thing

Fixes #6406

Auditors: @bbondy

Test Plan:

  1. Remove existing Brave and deleting existing brave-development folder from %appdata%
  2. Build from master
  3. Open about:brave, verify info is shown; rev may or may not be blank

…ak the whole thing.

Fixes #6406

Auditors: @bbondy

Test Plan:
1. Remove existing Brave and deleting existing brave-development folder from %appdata%
2. Build from master
3. Open about:brave, verify info is shown; rev may or may not be blank
@bbondy
Copy link
Member

bbondy commented Dec 23, 2016

++ but maybe it's something relating to not getting ipc events or something like that. I guess we will see in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants