Syncing styling #7152
Syncing styling #7152
Conversation
Also show device name Auditors: @diracdeltas
ayumi
force-pushed
the
feature/syncing-styling
branch
from
f9026e6
to
7dad719
Compare
|
[minor] the large right-side padding is a little weird some of the syncing tests are unstoked https://travis-ci.org/brave/browser-laptop/builds/200218416#L4843 |
| font-size: 18px; | ||
| font-family: monospace; | ||
| .browserButton + .browserButton { | ||
| margin-left: 0.75em; |
There was a problem hiding this comment.
I think this should be already covered with
browser-laptop/less/button.less
Line 52 in 2aa39bb
There was a problem hiding this comment.
5px was insufficient :)
| @@ -56,7 +65,7 @@ class SyncTab extends ImmutableComponent { | |||
| } | |||
| return this.props.syncQRVisible | |||
| ? <div> | |||
| <div><Button l10nId='syncHideQR' className='whiteButton syncToggleButton' onClick={this.props.hideQR} /></div> | |||
| <div><Button l10nId='syncHideQR' className='whiteButton wideButton syncToggleButton' onClick={this.props.hideQR} /></div> | |||
There was a problem hiding this comment.
Do we need wideButton for this? the min-width of the buttons has been set globally with #6387
There was a problem hiding this comment.
I applied this class as a hack to make the "button pressed / secret visible" state have a larger button. wideButton might be inappropriate so I can explicitly set a width for these buttons.
| @@ -76,7 +85,7 @@ class SyncTab extends ImmutableComponent { | |||
| ] | |||
| return this.props.syncPassphraseVisible | |||
| ? <div> | |||
| <Button l10nId='syncHidePassphrase' className='whiteButton syncToggleButton' onClick={this.props.hidePassphrase} /> | |||
| <Button l10nId='syncHidePassphrase' className='whiteButton wideButton syncToggleButton' onClick={this.props.hidePassphrase} /> | |||
|
@diracdeltas ran tests again which were successful. the test failures look to be intermittent and I'll try to address that in a separate PR. Adjusted switch/name spacing based on feedback: |
also show device name
Auditors: @diracdeltas