This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor download.js with Aphrodite #7258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
suggested changes
Feb 18, 2017
app/renderer/components/list.js
Outdated
| this.props['data-isDownload'] && styles.isDownload | ||
| ) | ||
|
|
||
| return <list className={className} {...this.props} /> |
There was a problem hiding this comment.
I don't think <list> is a valid element. Lists are tagged as grouping content and AFAICT this tag is not included as one. Can we replace that with just a div? btw ok to keep component name as List.
Ref: https://www.w3.org/community/webed/wiki/HTML/Elements#Grouping_content
| overflow: 'hidden', | ||
| whiteSpace: 'nowrap', | ||
| padding: '8px 12px', | ||
| WebkitUserSelect: 'none', |
luixxiul
added
PR/work-in-progress ⚒
PR/needs-QA-attention ☕
and removed
PR/needs-QA-attention ☕
PR/work-in-progress ⚒
labels
luixxiul
commented
Feb 20, 2017
| this.props['data-isDownload'] && styles.isDownload | ||
| ) | ||
|
|
||
| return <div className={className} {...this.props} /> |
There was a problem hiding this comment.
@cezaraugusto updated.
This was referenced Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including:
<List>and<DownloadList>in list.js&.selectedCloses #7255
Addresses #7318
Auditors: @bsclifton @cezaraugusto
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: