Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove about:preferences from web_accessible_resources #7484

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 3, 2017

fix #4913

Auditors: @bridiver

Test Plan:

  1. open about:preferences and open devtools
  2. the top-level HTTP response should not show an 'Access-Control-Allow-Origin' header
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 3, 2017
@diracdeltas
Copy link
Member Author

@feross relatedly, i noticed webtorrent exposes 'webtorrent.html' in web_accessible_resources. if this is not necessary i recommend removing it.

fix #4913

Auditors: @bridiver

Test Plan:
1. open about:preferences and open devtools
2. the top-level HTTP response should not show an 'Access-Control-Allow-Origin' header
@diracdeltas
Copy link
Member Author

merging based on #4913 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed access-control-allow-origin: * set on about: pages
2 participants