This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Follow up of https://github.com/brave/muon/pull/170 #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires brave/muon#170 fix #7763 fix #7768 Auditors: @bridiver, @bbondy, @bsclifton Test Plan: Covered by automatic test
darkdh
force-pushed
the
hide-autofill-popup
branch
from
3964c34
to
061d102
Compare
|
Automated test failed due to new muon requirement |
|
merging... |
bridiver
reviewed
Mar 21, 2017
| @@ -732,8 +732,7 @@ class Frame extends ImmutableComponent { | |||
| contextMenus.onShowAutofillMenu(e.suggestions, e.rect, this.frame) | |||
| }) | |||
| this.webview.addEventListener('hide-autofill-popup', (e) => { | |||
| if (this.props.contextMenuDetail && this.props.contextMenuDetail.get('type') === 'autofill' && | |||
| (this.props.contextMenuDetail.get('tabId') !== this.props.tabId || this.webview.isFocused())) { | |||
| if (this.props.contextMenuDetail && this.props.contextMenuDetail.get('type') === 'autofill') { | |||
There was a problem hiding this comment.
see comments on brave/muon#170
we call autofillPopupHidden with a tabId, but we don't bother to check that tabId before clearing the context menu detail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires brave/muon#170
fix #7763
fix #7768
Auditors: @bridiver, @bbondy, @bsclifton
Test Plan: Covered by automatic test
git rebase -ito squash commits (if needed).Test Plan: