Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Torrent viewer: Add 'Stop Download' button #7863

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Torrent viewer: Add 'Stop Download' button #7863

merged 1 commit into from
Apr 3, 2017

Conversation

feross
Copy link
Contributor

@feross feross commented Mar 23, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Click a torrent or magnet link from this list https://webtorrent.io/free-torrents
  2. Click 'Start Download'. The torrent detail view should appear.
  3. Wait a few seconds, click 'Stop Download'. The torrent start page with a 'Start Download' button should return, indicating the download has stopped.

Description

NOTE: Depends on #7351 being merged first

Fixes: #6768

stop-download

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@feross feross self-assigned this Mar 23, 2017
@feross feross added this to the 0.14.1 milestone Mar 23, 2017
@feross feross mentioned this pull request Mar 23, 2017
Closed
@bsclifton
Copy link
Member

rebased after merging #7351

bsclifton
bsclifton approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out- works great 😄 What's really nice is that you can stop the download completely... close and reopen the page... and then hit start again and it seemed to resume where it left off 👍 Well done

@bsclifton bsclifton merged commit 282c932 into master Apr 3, 2017
@bsclifton bsclifton deleted the feross/stop branch April 3, 2017 01:37
@feross feross mentioned this pull request Apr 13, 2017
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@alexwykoff alexwykoff Awaiting requested review from alexwykoff

Assignees

@feross feross

Labels
feature/torrent QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@feross @bsclifton