This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Only check third party url when not in main frame #7924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#7916 Auditors: @bbondy, @bsclifton Test Plan: - Make sure automated tests are passing - `npm run test -- --grep=adBlockUtil` - Make sure you don't see ads on YouTube. - Make sure `http://downloadme.org/` will be reported as malicious site
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7916
Auditors: @bbondy, @bsclifton
Test Plan:
Make sure automated tests are passing
npm run test -- --grep=adBlockUtilMake sure you don't see ads on YouTube.
Make sure
http://downloadme.org/will be reported as malicious siteSubmitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran
git rebase -ito squash commits (if needed).