This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update UI spec for private tabs #7944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
added
design
|
I added #547 as another issue to be closed with this PR. |
|
nice catch, thanks |
|
@bradleyrichter I personally prefer to have purple background all the time. This ways I can easily and more importantly faster see which tab is private. Other then that, this PR LGTM |
- Close #7943 - Auditors: @bsclifton
|
@NejcZdovc Did you also find that the colored non-selected private tab made it more difficult see which tab is selected? I think this problem is more severe than knowing if the tab is private before selection. But maybe I need to consider more use cases... |
|
@bradleyrichter you could create a follow up issue if it made sense- we could have logic which sets a light pastel purple when the private tab is not selected and the regular color purple when it is selected/active. I think this is a good compromise |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Mar 29, 2017
… of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg
cezaraugusto
pushed a commit
that referenced
this pull request
Mar 31, 2017
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
bsclifton
pushed a commit
that referenced
this pull request
Mar 31, 2017
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
bridiver
pushed a commit
that referenced
this pull request
Apr 4, 2017
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Close #7943
Close #547
Auditors: @bsclifton
Test Plan: