Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Left-align interactive sound indicator #8046

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Apr 2, 2017

Test Plan

  1. Go to a YouTube video
  2. Click/toggle the tab mute button
  3. Button should not jump around

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8041

@jonathansampson jonathansampson added feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. labels Apr 2, 2017
@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 2, 2017
@jonathansampson
Copy link
Collaborator Author

@cezaraugusto The only other symbol icon I can see is the loading icon. But this doesn't appear to impact that negatively, so I opted not to make a special-case handling for the sound icon. If you find that this fix does negatively impact the loading icon, we can do the special-case handling instead.

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used for the partitioned tab but has no impact on UI so LGTM ++ thanks

@cezaraugusto cezaraugusto merged commit 1f3cf4b into master Apr 6, 2017
@cezaraugusto cezaraugusto deleted the polish_audio-icon-position branch April 6, 2017 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/tabsbar polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants