Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Increase tabs bar height by 2px #8260

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Increase tabs bar height by 2px #8260

merged 1 commit into from
Apr 12, 2017

Conversation

jamesmudgett
Copy link
Contributor

@jamesmudgett jamesmudgett commented Apr 12, 2017 •
edited by bsclifton
Loading

Test plan

see #8263

Description

Fixes #8263

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

bradleyrichter
bradleyrichter approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Thanks.

@bsclifton bsclifton added release-notes/include design A design change, especially one which needs input from the design team. feature/tabsbar labels Apr 12, 2017
@jamesmudgett @bsclifton
Increase tabs bar height by 2px
99881bf 
Take some padding from bookmark bar

Fixes #8263
bsclifton
bsclifton approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows- looks great! 😄

@bsclifton bsclifton added this to the 0.14.2 milestone Apr 12, 2017
@bsclifton bsclifton merged commit 3c5619e into master Apr 12, 2017
@bsclifton bsclifton deleted the tabs-height branch April 12, 2017 22:03
@luixxiul
Copy link
Contributor

This change reduces the 3px margin between the top edge of the window and the URL bar, which is surely expected?

clipboard01

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Apr 13, 2017
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 13, 2017 via email

@luixxiul
Copy link
Contributor

luixxiul commented Apr 13, 2017 •
edited
Loading

it is that what I have mentioned, but maybe I should have paste the picture. will work on fix, with a new PR.

@luixxiul luixxiul mentioned this pull request Apr 13, 2017
Merged
@luixxiul luixxiul added reverted and removed needs-info Another team member needs information from the PR/issue opener. QA/test-plan-specified release-notes/include labels Apr 13, 2017
@luixxiul luixxiul removed this from the 0.14.2 milestone Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bradleyrichter bradleyrichter bradleyrichter approved these changes

Assignees

@jamesmudgett jamesmudgett

Labels
design A design change, especially one which needs input from the design team. feature/tabsbar reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesmudgett @luixxiul @bradleyrichter @bsclifton