This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Adds List validation for reduxComponent #8558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
changed the title
NejcZdovc
force-pushed
the
redux/list
branch
2 times, most recently
from
a315fff
to
578004f
Compare
51 tasks
bridiver
suggested changes
Apr 28, 2017
app/common/state/immutableUtil.js
Outdated
| @@ -17,6 +17,10 @@ const api = { | |||
| return Immutable.List.isList(obj) | |||
| }, | |||
|
|
|||
| isSame: (first, second) => { | |||
There was a problem hiding this comment.
to avoid confusion I think should probably is isSameHashCode
app/common/state/immutableUtil.js
Outdated
| @@ -17,6 +17,10 @@ const api = { | |||
| return Immutable.List.isList(obj) | |||
| }, | |||
|
|
|||
| isSame: (first, second) => { | |||
| return second !== null ? first.hashCode() === second.hashCode() : false | |||
There was a problem hiding this comment.
if both objects are null it should return true
| return Object.keys(nextState).some((prop) => nextState[prop] !== this.state[prop]) || | ||
| Object.keys(nextProps).some((prop) => nextProps[prop] !== this.props[prop]) | ||
| return Object.keys(nextState).some((prop) => { | ||
| return isList(nextState[prop]) |
There was a problem hiding this comment.
since this is a little more complicated now it would probably be better to pass an instance method to both instead of using anonymous functions. It would be slightly faster anyway and avoid the overhead of creating and GCing the closure
NejcZdovc
force-pushed
the
redux/list
branch
3 times, most recently
from
2686d23
to
82a7641
Compare
Resolves brave#8557 Auditors: @bridiver Test Plan: - create redux component - pass prop as a simple List - component should not update if props is the same
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #8557
Auditors: @bridiver
Test Plan: