Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bloodhound for URL bar suggestions & move suggestions to browser process #8824

Merged
merged 22 commits into from
May 18, 2017
Merged

Bloodhound for URL bar suggestions & move suggestions to browser process #8824

merged 22 commits into from
May 18, 2017

Commits on May 18, 2017

  1. Tokenize urlbar suggestions and use bloodhound

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    258b937 View commit details
    Browse the repository at this point in the history

  2. Change URL input entered into an app action

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    5b59bfe View commit details
    Browse the repository at this point in the history

  3. Don't store suggestion click handlers in state

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    cfeb861 View commit details
    Browse the repository at this point in the history

  4. Change URL suggestion generation to async

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    dd1bb22 View commit details
    Browse the repository at this point in the history

  5. Split out suggestion generation into parts

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    be7ad9f View commit details
    Browse the repository at this point in the history

  6. Make suggestions independent of windowState

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    c215ab3 View commit details
    Browse the repository at this point in the history

  7. Default search engine windowState -> appState

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    9cf76c0 View commit details
    Browse the repository at this point in the history

  8. Move suggestion files to common app dir

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    9d49e4b View commit details
    Browse the repository at this point in the history

  9. Move suggestion creation into the browser process

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    2d719a7 View commit details
    Browse the repository at this point in the history

  10. Use bloodhound lib for suggestions 

    Fix #7453
    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    4d89a15 View commit details
    Browse the repository at this point in the history

  11. Respect HISTORY and BOOKMARK suggestion settings

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    6fe984d View commit details
    Browse the repository at this point in the history

  12. Support history after bloodhound init

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    b02eeb3 View commit details
    Browse the repository at this point in the history

  13. Add tests for urlBarSuggestionsReducer 

    Also fixes various other failing unit tests
    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    7ff4a15 View commit details
    Browse the repository at this point in the history

  14. Fix search suggestions in browser process

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    08fd817 View commit details
    Browse the repository at this point in the history

  15. Debounce on suggestion generation

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    eeda733 View commit details
    Browse the repository at this point in the history

  16. Remove some imperative actions for clearing suggestion selectedIndex

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    6d3cade View commit details
    Browse the repository at this point in the history

  17. Tokenize with urlParse and for non urls

    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    46c7bf0 View commit details
    Browse the repository at this point in the history

  18. Fix some failing tests post suggestion changes 

    - search suggestions failing test
- tab tests tab transfer can detach into new windows
    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    1dab48d View commit details
    Browse the repository at this point in the history

  19. Improve sorting of results 

    This makes results appear much better now and fixes the various use cases you found
    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    b37785e View commit details
    Browse the repository at this point in the history

  20. Tab should cycle between results 

    Fix #5878

Auditors: @bsclifton
    @bbondy
    bbondy committed May 18, 2017
    1 Configuration menu
    Copy the full SHA
    afd891f View commit details
    Browse the repository at this point in the history

  21. Don't do suggestion actions on non-char key presses 

    Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
    @bbondy
    bbondy committed May 18, 2017
    1 Configuration menu
    Copy the full SHA
    ff41f60 View commit details
    Browse the repository at this point in the history

  22. Match entered paths better 

    Matches things better if the user puts a / in the input
    @bbondy
    bbondy committed May 18, 2017
    Configuration menu
    Copy the full SHA
    f94239a View commit details
    Browse the repository at this point in the history