Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unhide bitwarden password manager resolves #7921 #8829

Merged
merged 1 commit into from
May 11, 2017
Merged

Unhide bitwarden password manager resolves #7921 #8829

merged 1 commit into from
May 11, 2017

Conversation

kspearrin
Copy link
Contributor

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • Select bitwarden option from settings.

resolves #7921

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref

@kspearrin kspearrin mentioned this pull request May 11, 2017
Closed
4 tasks
@bsclifton bsclifton mentioned this pull request May 11, 2017
Closed
@cezaraugusto cezaraugusto self-requested a review May 11, 2017 19:51
cezaraugusto
cezaraugusto approved these changes May 11, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 6ae3be2 into brave:master May 11, 2017
cezaraugusto added a commit that referenced this pull request May 11, 2017
@cezaraugusto
Add extensionsTab test for bitwarden
8ad155a 
- Follow-up of #8829
- Auditors: @bsclifton
- Test Plan: npm run test -- --grep="ExtensionsTab component"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
feature/password-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhide bitwarden password manager
3 participants
@kspearrin @cezaraugusto @luixxiul