This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
follow ups to fix for #9308 #9407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ayumi
approved these changes
Jun 13, 2017
| @@ -296,6 +296,10 @@ module.exports.cleanAppData = (data, isShutdown) => { | |||
| if (data.dragData) { | |||
| delete data.dragData | |||
| } | |||
| if (data.sync) { | |||
| // clear sync site cache | |||
| data.sync.objectsById = {} | |||
There was a problem hiding this comment.
it probably shouldn't be recreated every time (my bad) but this is okay for now
diracdeltas
added a commit
that referenced
this pull request
Jun 13, 2017
follow ups to fix for #9308
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9405
fix #9404
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests