Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Converts FindBar into redux component #9426

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 13, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9338
Resolves #8877

Auditors: @bsclifton @bridiver

Test Plan:

  • find bar should open when you press cmd+f
  • check if find is working
  • check if result number is correct
  • check if find bar input is cleared when you open(put a in)/close/open in a private tab

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver merged commit 002d158 into brave:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redux component - Find bar Find bar lose focus if tab is opened in a background
3 participants