Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

do not error if createSiteData cannot build a siteKey #9431

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 13, 2017

fix #9430

Test Plan:

  1. enable sync
  2. visit https://www.google.com/#q=test
  3. enable the setting to clear browsing history when Brave is closed in about:preferences#security
  4. close and restart Brave
  5. you should see 'Ignoring entry because we can't create site key' in the console but no errors

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #9430

Test Plan:
1. enable sync
2. visit https://www.google.com/#q=test
3. enable the setting to clear browsing history when Brave is closed in about:preferences#security
4. close and restart Brave
5. you should see 'Ignoring entry because we can't create site key' in the console but no errors
@diracdeltas diracdeltas added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
@diracdeltas diracdeltas self-assigned this Jun 13, 2017
@diracdeltas diracdeltas requested a review from ayumi June 13, 2017 22:46
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥈

@diracdeltas diracdeltas merged commit c5718d0 into master Jun 13, 2017
@diracdeltas diracdeltas deleted the fix/9430 branch June 13, 2017 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Sync could not create siteKey' error
2 participants