Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert NoScriptInfo into redux #9494

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 15, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9447

Auditors: @bsclifton @bridiver

Test Plan:

  • go to a page and block script in bravery panel
  • click on no script icon
  • try to enable some scripts and see if they are loaded after reload

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 15, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 15, 2017
@NejcZdovc NejcZdovc force-pushed the redux/noScriptInfo branch 2 times, most recently from d24b848 to 17daebc Compare June 15, 2017 13:24
@NejcZdovc
Copy link
Contributor Author

I played around with this popup and I am not sure that work 100% (before refactoring). @diracdeltas can you please check if everything is working correctly. For me when I added one JS (with allow once) it was back in the list the next time I clicked on a noScript icon.

@diracdeltas
Copy link
Member

the test for this seems to pass https://travis-ci.org/brave/browser-laptop/jobs/243263806#L3044

@NejcZdovc NejcZdovc merged commit ee90736 into brave:master Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants