Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix scroll bar issues on bravery panel #9803

Merged
merged 1 commit into from
Jul 2, 2017
Merged

Fix scroll bar issues on bravery panel #9803

merged 1 commit into from
Jul 2, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 30, 2017 •
edited
Loading

Fixes #9802
Fixes #9296

Auditors: @cezaraugusto

Test Plan:

  1. Open twitter.com
  2. Open the bravery panel
  3. Expand a resouce list
  4. Hover on the scroll bar
  5. Make sure the cursor does not become cursor:text

Test Plan 2:

  1. Open https://https-everywhere.badssl.com/
  2. Expand a resouce list
  3. Make sure that the vertical scroll bar does not appear

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix scroll bar issues on bravery panel
d0498f6 
Fixes #9802

Auditors: @cezaraugusto

Test Plan:
1. Open twitter.com
2. Open the bravery panel
3. Expand a resouce list
4. Hover on the scroll bar
5. Make sure the cursor does not become `cursor:text`

Test Plan 2:
1. Open https://https-everywhere.badssl.com/
2. Expand a resouce list
3. Make sure that the scroll bar does not appear
@luixxiul luixxiul self-assigned this Jun 30, 2017
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 30, 2017
@luixxiul luixxiul added feature/shields polish Nice to have — usually related to front-end/visual tasks. labels Jun 30, 2017
@luixxiul
Copy link
Contributor Author

Please test on Windows as well to make sure that the scroll bar does no longer appear with one blocked resource, thanks!

@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 30, 2017 •
edited
Loading

@cezaraugusto do you think this also closes #9296?

cezaraugusto
cezaraugusto approved these changes Jul 2, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto
Copy link
Contributor

yes just updated PR description

@cezaraugusto cezaraugusto merged commit f650ce8 into brave:master Jul 2, 2017
@cezaraugusto
Copy link
Contributor

btw moving to 0.20.x

@cezaraugusto cezaraugusto modified the milestones: 0.20.x (Nightly Channel), 0.19.x (Developer Channel) Jul 2, 2017
This was referenced Jul 2, 2017
Closed
Closed
@luixxiul luixxiul deleted the compactBraveryPanel-polish branch July 2, 2017 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@luixxiul luixxiul

Labels
feature/shields polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @cezaraugusto