This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
allow website access with long press on backbutton #9853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
suggested changes
Jul 5, 2017
app/browser/tabs.js
Outdated
| @@ -798,7 +798,7 @@ const api = { | |||
|
|
|||
| goToIndex: (tabId, index) => { | |||
| const tab = getWebContents(tabId) | |||
| if (tab && !tab.isDestroyed() && tab.canGoToIndex(index)) { | |||
| if (tab && !tab.isDestroyed() && tab.goToIndex(index)) { | |||
There was a problem hiding this comment.
we don't want to call goToIndex twice, but we should check that index >= 0 and < the number of entries
cezaraugusto
force-pushed
the
longpress-backbutton
branch
from
8cdb9a9
to
11dc16b
Compare
bridiver
approved these changes
Jul 6, 2017
cezaraugusto
added a commit
that referenced
this pull request
Jul 6, 2017
allow website access with long press on backbutton
cezaraugusto
added a commit
that referenced
this pull request
Jul 6, 2017
allow website access with long press on backbutton
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bridiver, @luixxiul
Fix #9852
STR: