Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Command+L when in url bar with URL bar suggestion should select full URL #9928

Merged
merged 1 commit into from
Jul 15, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 9, 2017

There was also a lot of other fixes which moves things out of the
component and into the store.

Note that there are no state functions in use yet for the window
renderer so I didn't create them yet as part of this task and just
used immutableJS directly.

I also fixed some intermittents with this fix.

Fix #9914

Auditors: @bsclifton

Test Plan:

  1. Fully test url bar and suggestions thoroughly
  2. Type in some chars that lead to a autocomplete selection, press
    command+L and make sure it selects all text.

Automated test plan

npm run test -- --grep="selects full url when autocompleting with partial selection"

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy
Copy link
Member Author

bbondy commented Jul 9, 2017

I think this is done just marking as WIP until I see if tests pass on Travis, they pass locally.

There was also a lot of other fixes which moves things out of the
component and into the store.

Note that there are no state functions in use yet for the window
renderer so I didn't create them yet as part of this task and just
used immutableJS directly.

I also fixed some intermittents with this fix.

Fix #9914

Auditors: @bsclifton

Test Plan:
1. Fully test url bar and suggestions thoroughly
2. Type in some chars that lead to a autocomplete selection, press
command+L and make sure it selects all text.
@bbondy
Copy link
Member Author

bbondy commented Jul 13, 2017

Ready for review pls.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and work as expected 😄

@bsclifton
Copy link
Member

@bbondy I merged but am having trouble cherry-picking into 0.19.x. Can you help?

@bbondy
Copy link
Member Author

bbondy commented Jul 18, 2017

confirming this is in 0.19.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command+L when in url bar with URL bar suggestion should select full URL
3 participants