This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Update to use Ledger Bridge with chrome.hid #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
update-ledger-bridge
branch
from
30e611b
to
3aa2a9c
Compare
onyb
approved these changes
Jun 9, 2021
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#16206
This isn't planned to be a long term solution since we can use native code for this, but we might decide to expose this API to other extensions.
The code to mock the navigator.hid in a way that works in extensions is here:
brave/eth-ledger-bridge-keyring@6db82c1
It basically moves the code from the
gh-pageand then adapts it to use the adapter HID bridge.I didn't work on eth-ledger-bridge-keyring tests/linting since this is just temporary for us while the new wallet is being built. I did test things with my ledger device though and it worked.