This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Add webview event for security state changes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to address brave/browser-laptop#5490 and brave/browser-laptop#5238 Auditors: @bsclifton @bbondy
4 tasks
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Nov 9, 2016
Requires brave/muon#90 Fix #5238 Auditors: @bsclifton @darkdh Test Plan: 1. go to http://dev.ruby.sh/bpoc.html and it should not show up as secure TODO: add automated test for the hackerone issue
4 tasks
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Nov 9, 2016
Requires brave/muon#90 Fix #5238 Auditors: @bsclifton @darkdh Test Plan: 1. go to http://dev.ruby.sh/bpoc.html and it should not show up as secure TODO: add automated test for the hackerone issue
bridiver
reviewed
Nov 9, 2016
| void WebContents::SecurityStyleChanged( | ||
| content::SecurityStyle security_style, | ||
| const content::SecurityStyleExplanations& explanations) { | ||
| std::string type = "unknown"; |
There was a problem hiding this comment.
merging but see template<> struct Converter<atom::api::WebContents::Type> at the top of this file for converting between C++ types and JS for node apis
|
++ |
|
yup, i named it to be consistent with the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to address
brave/browser-laptop#5490 and
brave/browser-laptop#5238
Auditors: @bsclifton @bbondy