Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS WikiTemplate & update testscript #324

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

srirambv
Copy link
Contributor

Closes #322
Closes #323

PR contains:

Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @srirambv - it looks (great) to me (I haven't run it, yet). Conditional r+, assuming someone runs it or I get a chance to run it.

I was hoping to get further tweaks into https://github.com/brave/brave-browser/wiki/IPFS-Features before we incorporated it into a test script like this, but I won't rathole that here, and will submit follow-up PRs when I have a little more breathing room.

@kjozwiak mind running through this one, as you're more familiar with the setup and how it's supposed to work? It's clear I need to eke out some time to try this out.

@srirambv
Copy link
Contributor Author

@stephendonner we can always do a follow up PR for the wiki template update. Once @kjozwiak runs through it I'll get this merged. You can add a follow up PR for the template file whenever you have time.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an issue when attempting to create the Windows template as per:

Traceback (most recent call last):
  File "brave_testrun_generator.py", line 917, in <module>
    ipfs_testruns(ipfskey)
  File "brave_testrun_generator.py", line 811, in ipfs_testruns
    body=windows_template,
NameError: name 'windows_template' is not defined

Looks like windows_template isn't defined.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work!

@srirambv srirambv merged commit 9569b80 into brave:master Jul 6, 2021
@srirambv srirambv deleted the IPFS branch July 6, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IPFS tests to test generator script Add IPFS test sheet
3 participants