Adding PWA checks to desktop passes #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM; ++ - ship it! |
stephendonner
approved these changes
Mar 2, 2022
srirambv
requested changes
Mar 2, 2022
| @@ -35,6 +35,17 @@ | |||
| - [ ] Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction | |||
| - [ ] Delete Adblock folder from browser profile and restart browser. Visit `brave://components` and verify `Brave Ad Block Updater` downloads and update the component. Repeat for all Brave components | |||
|
|
|||
| #### PWA (Progressive Web Application) | |||
|
|
|||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues | |||
There was a problem hiding this comment.
This test should be split into two. One where the site asks you to install the PWA and the one where you install a shortcut (Not actually a PWA).
Install App - https://twitter.com / https://youtube.com
Install Shortcut - https://cnn.com / https://brave.com
| - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed | ||
| - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` |
There was a problem hiding this comment.
Need another test for uninstalling the app via brave://apps which also allows to clear the site data during uninstall
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed | ||
|
|
There was a problem hiding this comment.
Need another test for switching the site to PWA window from the main browser window
- Verify visiting the site in normal browser window provides an option to launch in PWA window if installed as PWA/Shortcut.
|
|
||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues | ||
| - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut |
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed | ||
| - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` | ||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab |
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues | ||
| - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed |
There was a problem hiding this comment.
Maybe update the test to mention it can be launched independent of browser process
| - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` | ||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed |
There was a problem hiding this comment.
This needs to be updated. If the PWA is not created to launch as a separate window it will relaunch the browser process and open it in a new tab
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed | ||
| - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` | ||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut |
| - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` | ||
| - [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab | ||
| - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut | ||
| - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #403