Update ios tests #529
Merged
Update ios tests #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srirambv
requested changes
Jul 11, 2023
Appreciate you reviewing this! Re-requested! |
srirambv
reviewed
Jul 24, 2023
srirambv
reviewed
Jul 24, 2023
srirambv
reviewed
Jul 24, 2023
srirambv
requested changes
Jul 24, 2023
Thanks, much appreciated! |
kjozwiak
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM 👍 It's definitely a good start but we should eventually remake this so it's easier to understand/follow for someone who doesn't run iOS manual passes often. For example, someone from the QA team that usually does desktop might have a hard time following these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamped the test cases in the wikitemplate for iOS to conform to our current testing. It turned out to be quite cumbersome. Open to suggestions on how to trim it down but we should be testing all of these items. We could always create a reduced version for smaller releases. Some sections can be removed (iPad Navigation)
I closed off #501 since it was stale.