Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test run generator #550

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update test run generator #550

merged 1 commit into from
Nov 27, 2023

Conversation

LaurenWags
Copy link
Member

Fix #542

Per the above issue,

  • commented out the ability to generate the "Reduced" set of test cases for both Desktop and Android as we no longer have designated mid-cycle maintenance releases where these reduced cases were used. Now, we will have the full manual pass (to be run for each major chromium bump version) and a set of basic checks which will be run for each hotfix (whether it contains a minor chromium bump or not).
  • updated the generation of manual passes to now create a Linux test run for the basic checks

Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

I checked for any obvious typos, saw none, and also verified the variables match, but I didn't run the patch locally, and defer ultimately to @kjozwiak

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Went through all the choices using --test true and everything worked/generated without issues. Nicely done.

@LaurenWags LaurenWags merged commit 85c020e into master Nov 27, 2023
1 check passed
@LaurenWags LaurenWags deleted the laurenwags-issue542 branch November 27, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test run generator
3 participants