Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTPS Everywhere component test #555

Closed
wants to merge 3 commits into from
Closed

Conversation

stephendonner
Copy link
Contributor

Fixes #554

@LaurenWags
Copy link
Member

The reference to this component should be removed from all templates. It is listed in https://github.com/brave/qa-resources/blob/master/WikiTemplate/Desktop/Major_CR_Bump/wikitemplate-majorChromiumBumpUpgrades.md as well, possibly others.

@stephendonner
Copy link
Contributor Author

The reference to this component should be removed from all templates. It is listed in https://github.com/brave/qa-resources/blob/master/WikiTemplate/Desktop/Major_CR_Bump/wikitemplate-majorChromiumBumpUpgrades.md as well, possibly others.

Thanks; searched GitHub and local files, and I've added the above removal, now, which was the only other one left.

Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link

@MadhaviSeelam MadhaviSeelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@@ -193,7 +193,7 @@
- [ ] `CertificateRevocation`
- [ ] `cffkpbalmllkdoenhmdmpbkajipdjfam`: `rs-ABPFilterParserData.dat` & `regional_catalog.json` (AdBlock)
- [ ] `gccbbckogglekeggclmmekihdgdpdgoe`: (Sponsored New Tab Images)
- [ ] `oofiananboodjbbmdelgdommihjbkfag`: HTTPSE
- [ ] `jicbkmdloagakknpihibphagfckhjdih`: `speedreader-updater.dat`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where this change snuck in from, but are they ok to sneak in, so I don't have to rebase/fix merge conflicts yet again, @LaurenWags ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it accurate? Not sure where this one came from either. FWIW I'm not seeing this one on a fresh install of 1.68.x - so we should be careful about adding something that is wrong.

@stephendonner stephendonner removed their assignment Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the test for HTTPS Everywhere for Brave from the testsheet
3 participants