Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifest V2 checks to full desktop manual pass template #601

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

LaurenWags
Copy link
Member

Fix #594

Added Manifest V2 Extension checks to full desktop manual pass per discussions under https://bravesoftware.slack.com/archives/C2J3NA3L7/p1723575334463169

Copy link

@ShivanKaul ShivanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work @LaurenWags.

@LaurenWags LaurenWags merged commit 7c6527d into master Aug 27, 2024
2 checks passed
@LaurenWags LaurenWags deleted the laurenwags-manifestv2 branch August 27, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding manifest v2 extensions check to manual pass
3 participants