fix: key was missing in kafka record #1862
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a getter for missing key property.
|
Thanks, can you update the tests too? |
|
Thanks for letting me know @mnapoli. Added now. |
|
Can you fix the build? |
GrahamCampbell
suggested changes
Sep 23, 2024
src/Event/Kafka/KafkaRecord.php
Outdated
| @@ -18,6 +18,11 @@ public function __construct(mixed $record) | |||
| } | |||
| $this->record = $record; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The issue is that this line contains 4 spaces. It should contain 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a getter for missing key property because it was missing.
As per the official SDK for Java: https://github.com/aws/aws-lambda-java-libs/blob/main/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/KafkaEvent.java