Alternative Prometheus metrics Histogram instead of locking Summary. #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2018 11:49
Add PrometheusHistogramMetricsTracker.java that uses an internal Histogram instead of Summary. A summary is quite lock heavy. See: prometheus/client_java#328
Codecov Report
@@ Coverage Diff @@
## dev #1265 +/- ##
======================================
Coverage ? 74.53%
Complexity ? 557
======================================
Files ? 24
Lines ? 1940
Branches ? 265
======================================
Hits ? 1446
Misses ? 349
Partials ? 145Continue to review full report at Codecov.
|
kollstrom
pushed a commit
to kollstrom/HikariCP
that referenced
this pull request
Feb 4, 2021
…rettwooldridge#1265) * Alternative Prometheus metrics Histogram instead of locking Summary. Add PrometheusHistogramMetricsTracker.java that uses an internal Histogram instead of Summary. A summary is quite lock heavy. See: prometheus/client_java#328 * Fix incorrect magnitudes of buckets.
kollstrom
pushed a commit
to kollstrom/HikariCP
that referenced
this pull request
Feb 4, 2021
…rettwooldridge#1265) * Alternative Prometheus metrics Histogram instead of locking Summary. Add PrometheusHistogramMetricsTracker.java that uses an internal Histogram instead of Summary. A summary is quite lock heavy. See: prometheus/client_java#328 * Fix incorrect magnitudes of buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PrometheusHistogramMetricsTracker.java that uses an internal
Histogram instead of Summary. A summary is quite lock heavy.
See: prometheus/client_java#328