Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use [testcontainers-java] for Postgres unit test #1430

Merged

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Aug 13, 2019

No description provided.

@sullis sullis marked this pull request as ready for review August 14, 2019 23:23
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #1430 (2633eaa) into dev (8217f20) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1430      +/-   ##
============================================
+ Coverage     70.11%   70.25%   +0.14%     
- Complexity      561      563       +2     
============================================
  Files            26       26              
  Lines          2118     2118              
  Branches        296      296              
============================================
+ Hits           1485     1488       +3     
+ Misses          487      484       -3     
  Partials        146      146              
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 72.34% <0.00%> (-1.07%) 38.00% <0.00%> (-1.00%)
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java 81.36% <0.00%> (+0.35%) 59.00% <0.00%> (ø%)
src/main/java/com/zaxxer/hikari/HikariConfig.java 77.68% <0.00%> (+0.57%) 124.00% <0.00%> (+2.00%)
...n/java/com/zaxxer/hikari/pool/ProxyConnection.java 79.39% <0.00%> (+0.60%) 52.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8217f20...2633eaa. Read the comment docs.

@sullis sullis force-pushed the testcontainers-postgres branch 2 times, most recently from 1bef201 to c121da5 Compare November 30, 2020 07:54
@sullis
Copy link
Contributor Author

sullis commented Dec 26, 2020

@brettwooldridge WDYT?

@brettwooldridge brettwooldridge merged commit 99c213e into brettwooldridge:dev Jan 7, 2021
@sullis sullis deleted the testcontainers-postgres branch January 7, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants