Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements in unit tests. #608

Merged
merged 3 commits into from
Jul 6, 2014

Commits on Jun 15, 2014

  1. Miscellaneous improvements in unit tests.

    End statements with semicolons, to be consistent with the surrounding
    code.
    
    Added a new unit test to ensure environment variables are honored when
    parsing a
    connection string.
    
    Added a TODO to cleanup a test that emits messages using console.log().
    
    Correct a query's syntax. Looks like a good thing to do even though the
    syntax
    doesn't matter in mocked out tests.
    
    Removed a test that tests for SELECT tags; AFAIK, SELECT commands don't
    emit a
    tag.
    gurjeet committed Jun 15, 2014
    Configuration menu
    Copy the full SHA
    6530ce2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2014

  1. Update a test to pass.

    gurjeet committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    23b29c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2014

  1. Re-add the test for SELECT tag; I was wrong in my assumption.

    Postgres generally does not emit a SELECT tag after a SELECT query, but
    it does emit that tag after a CREATE TABLE x AS SELECT query.
    
    Example:
    
    postgres=# create table t as select 1;
    SELECT 1
    gurjeet committed Jun 22, 2014
    Configuration menu
    Copy the full SHA
    ef40b6f View commit details
    Browse the repository at this point in the history