Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to pg-connection-string module for parsing #615

Merged
merged 1 commit into from
Jul 6, 2014

Conversation

phated
Copy link
Contributor

@phated phated commented Jul 5, 2014

I needed to use the parse method in another module so I pulled it out into its own module. I also used tests from node-postgres that related to connection strings.

@brianc
Copy link
Owner

brianc commented Jul 6, 2014

Really cool! Would you mind resolving the merge conflict? I'll merge it up right after that. 😄

@phated
Copy link
Contributor Author

phated commented Jul 6, 2014

Rebased and made sure to move the change from #604 to pg-connection-string (published as 0.1.1).

@brianc
Copy link
Owner

brianc commented Jul 6, 2014

awesome!

brianc added a commit that referenced this pull request Jul 6, 2014
switch to pg-connection-string module for parsing
@brianc brianc merged commit ec81ff1 into brianc:master Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants