Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-115484 Token definition registry #91176

Closed
wants to merge 6 commits into from
Closed

LPS-115484 Token definition registry #91176

wants to merge 6 commits into from

Commits on Jul 10, 2020

  1. LPS-115484 Create new bundles for token definitions API and implement… 

    …ation
    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    09b3444 View commit details
    Browse the repository at this point in the history

  2. LPS-115484 Create a class to detect and describe theme bundles

    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    80b5f03 View commit details
    Browse the repository at this point in the history

  3. LPS-115484 Define and implement the token definitions API 

    Note that themes are WAR files, not OSGi bundles, so people need to add
the Token-Definition-Path header to the
liferay-plugin-package.properties file to make it appear in the
MANIFEST.MF file of the generated OSGi bundle.
    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f7a1e77 View commit details
    Browse the repository at this point in the history

  4. LPS-115484 Rename method to prevent future collisions 

    It is possible that in the future we have another method returning structured data, so we suffix this one with "String" to leave room for the other method.

See liferay-frontend#87 (comment) .
    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    6188ff4 View commit details
    Browse the repository at this point in the history

  5. LPS-115484 Fix broken test

    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    2d0c81a View commit details
    Browse the repository at this point in the history

  6. LPS-115484 Rename ThemeTokenDefinitions to ThemeTokenDefinitionRegist… 

    …ry to avoid ambiguity

We cannot call the service ThemeTokenDefinition because if we model the String in the future with a more complex object we may collide.
    @izaera
    izaera committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7b4fdb5 View commit details
    Browse the repository at this point in the history