LPS-115484 Token definitions API and implementation #91387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See liferay-frontend#119 (comment) for more information.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
| ], | ||
| "tokens": [ | ||
| { | ||
| "cssVariable": "white", |
There was a problem hiding this comment.
@eduardoallegrini @izaera
The mappings to a cssVariable need to adapted to:
{
"editorType": "ColorPicker",
"label": "gray-100",
"mappings": [
{
"type": "cssVariable",
"value": "gray-100"
}
],
"name": "gray100Color",
"tokenCategoryName": "colors",
"tokenSetName": "general",
"type": "String"
}
as discussed here so the token-definition.json file conforms with the updated JSON schema
|
ci:close |
|
I will resend the PR with the chnages and a new service that is needed. |
liferay-continuous-integration
deleted the
ci-forward-LPS-115484-pr-111-sender-izaera-ts-1594828246293
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#111 (Took 2
ci:forwardattempts in 1 hour 19 minutes)@izaera
@liferay-frontend
Original pull request comment:
This PR defines the initial token definitions API and implementation. We will iterate on this PR to refine the API and maybe provide more functionality.
Initially we sent #91176 to Brian, but he made some objections which led to a full rework of the PR.
The main reasons to rework the PR were:
So, after reviewing the three points we came up with a model where token definitions are associated to OSGi Bundles alone, not related to themes yet (this PR).
In the future we may provide tools to map from themes to OSGi bundles. Even if the existence of a bundle that contains the theme is not enforced by the portal we can define it as a requisite if you want to use token definitions and nothing would break/become inconsistent.
Also, the current API just lists all available token definitions, but doesn't let you query by any criteria. We may add more methods to the
TokenDefinitionRegistryservice in the future to query token definitions as needed.This PR doesn't modify anything in the UI nor does it execute any code (because nobody uses
TokenDefinitionRegistryyet). However, I have provided units tests to cover almost all production code.In addition, once we add the
token-definition.jsonfile in classic-theme, I will test it manually to make sure it runs in production too.✔️ ci:test:stable - 20 out of 20 jobs passed
✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 17 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: e67026449a8a6dae28fc7a7da27e3ff6a3f780b6
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 2d61577aa6a76425e17132e68f5aa901f720a686
ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 46 out of 46 jobs PASSED
46 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 76f17290c7dd17e02dbd73c3babb438de273a272
Sender Branch:
Branch Name: LPS-115484
1 out of 1jobs PASSEDBranch GIT ID: 22a8281702d74493785158383631f9a351e322b3
1 Successful Jobs:
For more details click here.