Skip to content

Commit

Permalink
Do not show the database uri in migration error message (mlflow#1365)
Browse files Browse the repository at this point in the history
It was showing the auth information as well and being sent to the REST API client as part of the response.
  • Loading branch information
sueann committed May 30, 2019
1 parent 10db784 commit a11a02d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions mlflow/store/sqlalchemy_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,10 @@ def _verify_schema(engine):
if current_rev != head_revision:
raise MlflowException(
"Detected out-of-date database schema (found version %s, but expected %s). "
"Take a backup of your database, then run 'mlflow db upgrade %s' to migrate "
"your database to the latest schema. NOTE: schema migration may result in "
"database downtime - please consult your database's documentation for more "
"detail." % (current_rev, head_revision, str(engine.url)))
"Take a backup of your database, then run 'mlflow db upgrade <database_uri>' "
"to migrate your database to the latest schema. NOTE: schema migration may "
"result in database downtime - please consult your database's documentation for "
"more detail." % (current_rev, head_revision))

@staticmethod
def _get_managed_session_maker(SessionMaker):
Expand Down

0 comments on commit a11a02d

Please sign in to comment.