Skip to content

Commit

Permalink
Remove conditional import of XibContext (lyft#42)
Browse files Browse the repository at this point in the history
This was a workaround for PyCQA/pyflakes#247.
  • Loading branch information
ikonst authored Mar 13, 2019
1 parent 732d69b commit 985ba29
Show file tree
Hide file tree
Showing 14 changed files with 14 additions and 42 deletions.
4 changes: 1 addition & 3 deletions xiblint/rules/accessibility_format.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
import re

from xiblint.rules import Rule
from xiblint.xibcontext import XibContext
from xiblint.xibutils import (
get_object_id,
get_view_user_defined_attr,
view_accessibility_identifier,
)

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext


class AccessibilityFormat(Rule):
"""
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/accessibility_labels_for_image_buttons.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
from xiblint.rules import Rule
from xiblint.xibcontext import XibContext
from xiblint.xibutils import (
view_is_accessibility_element,
view_accessibility_label,
get_view_user_defined_attr,
)

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext


class AccessibilityLabelsForImageButtons(Rule):
"""
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/accessibility_labels_for_images.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
from xiblint.rules import Rule
from xiblint.xibcontext import XibContext
from xiblint.xibutils import (
view_is_accessibility_element,
view_accessibility_label,
get_view_user_defined_attr,
)

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext


class AccessibilityLabelsForImages(Rule):
"""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
from xiblint.rules import Rule
from xiblint.xibcontext import XibContext
from xiblint.xibutils import (
get_view_user_defined_attr,
view_is_accessibility_element,
)

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext


class AccessibilityLabelsForTextWithPlaceholder(Rule):
"""
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/autolayout_frames.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class AutolayoutFrames(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/automation_identifiers.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class AutomationIdentifiers(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/automation_identifiers_for_outlet_labels.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class AutomationIdentifiersForOutletLabels(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/no_simulated_metrics.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class NoSimulatedMetrics(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/no_trait_variations.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class NoTraitVariations(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/no_view_controller_links_to_other_bundles.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class NoViewControllerLinksToOtherBundles(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/simulated_metrics_retina4_0.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext

ALLOWED_DEVICES = [
'retina4_0',
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/strict_font_names.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class StrictFontNames(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/unavailable_custom_classes.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
from xml.etree.ElementTree import Element

from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class UnavailableCustomClasses(Rule):
Expand Down
4 changes: 1 addition & 3 deletions xiblint/rules/unavailable_system_classes.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
from xml.etree.ElementTree import Element

from xiblint.rules import Rule

if False: # if TYPE_CHECKING:
from xiblint.xibcontext import XibContext
from xiblint.xibcontext import XibContext


class UnavailableSystemClasses(Rule):
Expand Down

0 comments on commit 985ba29

Please sign in to comment.