Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to readable-stream 3.0.0 #18

Merged
merged 19 commits into from
Apr 16, 2020
Merged

Update to readable-stream 3.0.0 #18

merged 19 commits into from
Apr 16, 2020

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Nov 19, 2018

Closes #17
Closes #22
Closes #24

@goto-bus-stop
Copy link
Member Author

rs@3 is significantly different in the browser and in node so we probably need some browserified tests here. it also drops support for some browser versions but i think its support is now the same as Buffer's so that's ok.

@3cp
Copy link

3cp commented Dec 13, 2018

Anyone reviewing this? readable-stream v3 is now 3.0.6 btw.

@goto-bus-stop
Copy link
Member Author

there are still some problems with this unfortunately. i had some runtime crashes involving util.inspect.custom (which IIRC is not yet available in browserify's util)

@arahmanan
Copy link

@goto-bus-stop I believe there have been some changes with the use of util.inspect.custom in the more recent versions of readable-stream (starting from v.3.1.0). Do those address the issues you were running into? Let me know if I can help in any way.

@goto-bus-stop
Copy link
Member Author

@arahmanan it looks like it! that means this should almost be ready. i requested a saucelabs.com account for browserify so we can add some browser tests, i would like to be a bit more certain about what we support. especially because readable-stream now has slight implementation differences in the browser version and the node.js version for compatibility reasons. once that's set up, this can finally be released :)

@goto-bus-stop
Copy link
Member Author

status update: saucelabs approved the request quickly, but I ran into some trouble claiming it. I only just finally emailed them about it, hopefully it can be resolved soon!

@guybedford
Copy link

@goto-bus-stop would you consider forking and publishing this update yourself? I'm currently looking into updating these builtins in jspm (https://github.com/jspm/jspm-core) and this would be great to avoid the duplication that now comes into effect since http has upgraded.

@goto-bus-stop goto-bus-stop merged commit d03ad01 into master Apr 16, 2020
@goto-bus-stop goto-bus-stop deleted the readable-stream-3 branch April 16, 2020 12:42
@goto-bus-stop
Copy link
Member Author

Saucelabs says yes! 📦 stream-browserify@3.0.0

@guybedford
Copy link

Amazing, persistence pays off :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants