Fix TSAbstractPropertyDefinition being treated as a method instead of…

… a property. fixes #84
bryanrsmith · Apr 11, 2023 · 30bd9ef · 30bd9ef
1 parent 6fb838e
commit 30bd9ef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/rules/sort-class-members.js b/src/rules/sort-class-members.js
@@ -192,7 +192,8 @@ function getMemberInfo(node, sourceCode) {
 		node.type === 'ClassProperty' ||
 		node.type === 'ClassPrivateProperty' ||
 		node.type === 'PropertyDefinition' ||
-		node.type === 'PrivateIdentifier'
+		node.type === 'PrivateIdentifier' ||
+		node.type === 'TSAbstractPropertyDefinition'
 	) {
 		type = 'property';
 

diff --git a/test/rules/sort-class-members.spec.js b/test/rules/sort-class-members.spec.js
@@ -402,6 +402,11 @@ ruleTester.run('sort-class-members', rule, {
 			options: typescriptKeywordsOptions,
 			parser: require.resolve('@typescript-eslint/parser'),
 		},
+		{
+			code: 'abstract class Foo<T> { protected abstract readonly _foo: T; public readonly bar: string; protected constructor(bar: string) {}}',
+			options: [{ order: ['[properties]', 'constructor', '[methods]'] }],
+			parser: require.resolve('@typescript-eslint/parser'),
+		},
 	],
 	invalid: [
 		{
@@ -919,7 +924,7 @@ ruleTester.run('sort-class-members', rule, {
 			output: 'class { override b; abstract a;  }',
 			errors: [
 				{
-					message: 'Expected property b to come before method a.',
+					message: 'Expected property b to come before property a.',
 					type: 'PropertyDefinition',
 				},
 			],