Fix AC key mangling for grpc server #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchgr#339 implemented AC key mangling based on instance name. However, that implementation missed applying the mangling logic on grpc UpdateActionResult method, causing cached entries to not match the ones fetched by GetActionResult. Correctly implement the feature on that method and add test to verify the new behavior.
mostynb
reviewed
Oct 22, 2022
| @@ -92,7 +92,7 @@ func TestMain(m *testing.M) { | |||
| listener = bufconn.Listen(bufSize) | |||
|
|
|||
| validateAC := true | |||
| mangleACKeys := false | |||
| mangleACKeys := true | |||
There was a problem hiding this comment.
This now means that we aren't testing the regular non-mangled AC key case. I will refector the grpc tests in #594 to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#339 implemented AC key mangling based on instance name. However, that implementation missed applying the mangling logic on grpc UpdateActionResult method, causing cached entries to not match the ones fetched by GetActionResult. Correctly implement the feature on that method and add test to verify the new behavior.