Skip WKT files when exporting #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
requested changes
Feb 22, 2024
| @@ -176,6 +177,10 @@ func run( | |||
| return errors.New("no .proto target files found") | |||
| } | |||
| for _, imageFile := range image.Files() { | |||
| if datawkt.Exists(imageFile.Path()) { | |||
There was a problem hiding this comment.
This isn't what you want - this will ignore a file if it has the same name as a WKT, regardless of if that file was actually either (1) in your module or (2) an actual dependency. Examples from old CLI that will export the file, but will not after this change:
- A module with a dep on
buf.build/protocolbuffers/wellknowntypes. - A module that has a file named
google/protobuf/timestamp.protolocally.
There was a problem hiding this comment.
you're right, I'll fix
There was a problem hiding this comment.
Looked into it, fixed in 3c4812b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.