Fix for protoc plugin extension reparse issue #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
reviewed
Sep 10, 2024
| protoplugin.Main( | ||
| protoplugin.HandlerFunc(handle), | ||
| protoplugin.WithUnmarshalOptions(proto.UnmarshalOptions{ | ||
| Resolver: (*protoregistry.Types)(nil), |
There was a problem hiding this comment.
I don't understand what this is doing and why - needs extensive code comments
There was a problem hiding this comment.
The code has been made clearer, no more typed nil.
bufdev
changed the title
doriable
reviewed
Sep 10, 2024
bufdev
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to the bug described in #3306. Paired with protoplugin changes that allow it, this ensures that gencode shipped with buf CLI does not interfere with the reparse process by prematurely resolving extensions to the gencode versions.
(Draft until protoplugin has an appropriate interface we can use upstream. This interim version uses a
replacedirective just to demonstrate that it does indeed fix the problem.)