Run bufcheck WithPlugins option #3327
Conversation
Moves the bufconfig.PluginConfig to be provided with the plugin runner as a Plugin. This allows for setting the pluginrpc.Runner based on the config.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| type RunnerProvider interface { | ||
| NewRunner(programName string, programArgs ...string) pluginrpc.Runner | ||
| // Plugin is a configured lint or breaking plugin that wraps a pluginrpc.Runner. | ||
| type Plugin interface { |
There was a problem hiding this comment.
I don't fully understand this interface - it doesn't make sense to me why a Plugin is a Runner. Should I be able to execute arbitrary arguments on a Plugin? Almost for sure no.
There was a problem hiding this comment.
A plugin is run/invoked so I think having a method Run makes sense. Although maybe the interface name shouldn't be Runner as that does imply handling multiple.
There was a problem hiding this comment.
I probably should have been more direct, apologies - I don't think the interface signature makes sense here. I'm not super convinced by this change as a whole, wondering if your RunnerProvider idea might be less invasive.
Moves the
bufconfig.PluginConfigto be provided with thepluginrpc.Runneras abufcheck.Plugin. This allows for setting the runner based on the configuration of the plugin. Removes the default runner as this is now provided when invoking a bufcheck check using the newWithPluginsclient function option that replacesWithPluginConfigs.RunnerProvideris removed. A helperNewPluginsForRunneris provided to map local plugins to acommand.Runner.