Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky zip archive test #3367

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix flaky zip archive test #3367

merged 1 commit into from
Oct 3, 2024

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Oct 3, 2024 •
edited
Loading

Eagerly close the file by using storage.PutPath. The logic on t.Cleanup looks correct but we don't need to hold the file open for the entire test.

--- FAIL: TestWorkspaceNestedArchive (6.49s)
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestWorkspaceNestedArchive931609167\006\testdata\workspace\success\v2\nested\archive.zip: The process cannot access the file because it is being used by another process.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 3, 2024, 4:43 PM

@emcfarlane emcfarlane changed the title Fix TestWorkspaceNestedArchive flake Fix flaky zip archive test Oct 3, 2024
@emcfarlane emcfarlane merged commit 529f629 into main Oct 3, 2024
15 checks passed
@emcfarlane emcfarlane deleted the ed/fixFlakyClose branch October 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliversun9 oliversun9 oliversun9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emcfarlane @oliversun9