Fixes for 3.2.55 (tier 3) #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
virxkane
commented
Apr 18, 2021
•
virxkane
commented
- Don't call onCancel listener in 'check download setting' dialog if positive or negative button is pressed.
- Synchronization: deleting the lock file on failure or cancellation.
- Synchronizer related: fixed scanning of just downloaded books in zip-archive.
- InputDialog: the cursor position is retained while dragging the slider.
if positive or negative button is pressed.
omitted 'return' keyword that broke fallback font measurements with HarfBuzz light rendering.
poire-z
reviewed
Apr 27, 2021
Comment on lines
-1648
to
+1649
| if ( !isHyphen ) // avoid soft hyphens inside text string | ||
| prev_width = cur_width; | ||
| prev_width = cur_width; |
There was a problem hiding this comment.
Was this change voluntary ? Or is this taken care of elsewhere?
I think isHyphen maks soft-hyphens, that is a glyph that has a width. We don't draw them, so keeping their width in measureText() (as you're doing now here) might result in measureText() measuring words larger that what they will be when drawn.
There was a problem hiding this comment.
This is dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.