[RB] Show full child command in UI #7402
Conversation
maggie-lou
force-pushed
the
child_full_command
branch
5 times, most recently
from
341115b
to
1b3d455
Compare
maggie-lou
force-pushed
the
child_full_command
branch
3 times, most recently
from
603e33a
to
325af06
Compare
maggie-lou
changed the title
maggie-lou
force-pushed
the
child_full_command
branch
from
325af06
to
8f1fc78
Compare
maggie-lou
force-pushed
the
child_full_command
branch
from
8f1fc78
to
60cc342
Compare
| // Remove the bazel command string | ||
| if (commandLine.startsWith("bazel ")) { | ||
| commandLine = commandLine.slice("bazel ".length); | ||
| } | ||
|
|
||
| // Strip all --remote_header flags | ||
| commandLine = commandLine.replace(/\s*--remote_header=[^\s]+/g, ""); | ||
| // Strip the options we manually added | ||
| commandLine = commandLine.replace(" --config=buildbuddy_bes_backend", ""); | ||
| commandLine = commandLine.replace(" --config=buildbuddy_bes_results_url", ""); | ||
| commandLine = commandLine.replace(" --config=buildbuddy_remote_cache", ""); | ||
| commandLine = commandLine.replace(/\s*--invocation_id=[^\s]+/g, ""); | ||
|
|
||
| return commandLine; |
There was a problem hiding this comment.
We have EXPLICIT_COMMAND_LINE that is intended as a way to override the bazel command displayed in the UI in cases where there is some extra arg fiddling going on (e.g. the CLI) - can we set that build metadata and use it directly instead of "undoing" the arg fiddling here?
There was a problem hiding this comment.
I realized that the redactor strips EXPLICIT_COMMAND_LINE from the build metadata, so that is actually an ineffective way to override the bazel command displayed in the UI (Here's a PR to remove the code from the CLI. Alternatively, we could add it back and risk there being places we are incorrectly redacting it, which was the original impetus to remove it)
There was a problem hiding this comment.
the redactor strips EXPLICIT_COMMAND_LINE from the build metadata
I think the linked code is stripping one of the CommandLine events, not the BuildMetadata event?
There was a problem hiding this comment.
after a closer look, that linked code is stripping any nested occurrences of --build_metadata=EXPLICIT_COMMAND_LINE= within the explicit command line (which shouldn't normally happen), but the EXPLICIT_COMMAND_LINE build metadata is still preserved in the BuildMetadata event
Currently, the UI will only show the command and the pattern - i.e.
build //.... Show the full explicit command line to include all flags specified by the userRelated issues: N/A