Add back preferred runtime env with option #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper reduces the boiler plate needed and allows us to add unexported variables to Pipeline struct without much fuss
This preserves the v0.4.0->v0.7.0 behaviour which was reverted in v0.8.0
DrJosh9000
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Storing preferRuntimeEnv inside Pipeline in order to maybe use it later on doesn't make a lot of sense to me. I think it makes more sense as an arg on the Interpolate method.
As long as the module is still v0.something and we are the overwhelming majority of users of it, I wouldn't worry about breaking API compatibility.
Prefer a simpler, breaking change, over an unnecessary backwards compatibility change
Co-authored-by: Josh Deprez <jd@buildkite.com>
patrobinson
force-pushed
the
add-back-prefered-runtime-env-with-option
branch
from
bc55088
to
e678690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #35 we reverted a breaking change to the way we interpolate environment variables.
This PR adds a flag to optionally enable the functionality that was introduced in v0.4.0.
Instead of adding back the tests I undid in #35 I opted to add new tests in
parser_test.go, which is where this functionality exists, interpolate just does the interpolation,pipeline.godecides the precedence of variables.